Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ES|QL] open suggestions automatically in sources lists and `ENRICH` (#191312) #193013

Merged
merged 1 commit into from
Sep 16, 2024

Commits on Sep 16, 2024

  1. [ES|QL] open suggestions automatically in sources lists and ENRICH (e…

    …lastic#191312)
    
    ## Summary
    
    Part of elastic#189662
    
    Also, a follow-on to elastic#187184
    with certain source names (e.g. `foo$bar`, `my-policy`) and fields in
    the `ENRICH` command.
    
    During this effort I discovered
    elastic#191321 and a bug with the
    validation of field names in the "ENRICH ... WITH" list (documented
    [here](elastic#177699)), both of which
    will be addressed separately.
    
    ## Sources
    
    ### General flow
    
    https://github.com/user-attachments/assets/4b103621-0e66-4c36-807f-4932f0cb8faf
    
    ### Works with wild-card matches
    
    https://github.com/user-attachments/assets/6b47fffc-e922-4e2d-b6aa-3d9a2fc2236c
    
    ### `METADATA` field list
    
    https://github.com/user-attachments/assets/d3bdf4dc-1d0c-4d56-81d7-af6bc4e25a4a
    
    ## ENRICH
    
    Autosuggest now helps you along
    
    https://github.com/user-attachments/assets/d627484c-e729-4dc7-9e7b-795395a31d4f
    
    Also, fixed this bug (follow on to
    elastic#187184 )
    
    https://github.com/user-attachments/assets/aa62a0c3-6db5-434a-829a-59f14c5c4c85
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
    Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
    (cherry picked from commit e404a39)
    drewdaemon committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dc2a64e View commit details
    Browse the repository at this point in the history