[Fleet] Fix bulk GET agent policies permissions #193070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
added
backport:prev-minor
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 16, 2024
(cherry picked from commit 8c8696d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 16, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Fix bulk GET agent policies permissions (#193070)](#193070) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2024-09-16T20:14:29Z","message":"[Fleet] Fix bulk GET agent policies permissions (#193070)","sha":"8c8696d537b3661c72d98f9ed50d2922d77d5142","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Fix bulk GET agent policies permissions","number":193070,"url":"https://github.com/elastic/kibana/pull/193070","mergeCommit":{"message":"[Fleet] Fix bulk GET agent policies permissions (#193070)","sha":"8c8696d537b3661c72d98f9ed50d2922d77d5142"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193070","number":193070,"mergeCommit":{"message":"[Fleet] Fix bulk GET agent policies permissions (#193070)","sha":"8c8696d537b3661c72d98f9ed50d2922d77d5142"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
markov00
pushed a commit
to markov00/kibana
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #191957
In #191661 we switched to fetch all agent policies to use the bulk GET api for agent policies.
That API was not allowed for user with agent read permissions, that PR fix that by allowing it, that API return a sanitized agent policy version just the name and description and no package policies if the user do not have the
AgentPolicies:ReadpermissionsTest
I added unit test to cover those scenarios.