-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add TheHive connector to automated Observability case screenshots #193913
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but maybe we dont need all the retry.waitFor
? The failing tests you linked were only about common-flyout-cancel
.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Relates to #180931
This PR adds TheHive connector to the automated screenshot that is used in https://www.elastic.co/docs/current/serverless/observability/case-settings#create-a-connector
The screenshot automation for that page and for https://www.elastic.co/docs/current/serverless/security/cases-settings#external-incident-management-systems had been turned off per #188997 and #189058
I could not replicate those timeout errors, but I added
retry.waitFor
around any clicks since that's what seems to be done in https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.tsI have also removed one of the automated screenshots that is no longer required per elastic/security-docs#5859