[Security GenAI] Remove assistantNaturalLanguageESQLTool feature flag and enable by default
#195480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:enhancement
v9.0.0
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
patrykkopycinski
approved these changes
Oct 8, 2024
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11256813292 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
that referenced
this pull request
Oct 10, 2024
…ure flag and enable by default (#195480) (#195674) # Backport This will backport the following commits from `main` to `8.x`: - [[Security GenAI] Remove `assistantNaturalLanguageESQLTool` feature flag and enable by default (#195480)](#195480) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T14:13:05Z","message":"[Security GenAI] Remove `assistantNaturalLanguageESQLTool` feature flag and enable by default (#195480)","sha":"3dd1ee8ae00a40b582f2d1f784c96269a1d2e016","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","Team: SecuritySolution","backport:prev-minor","Feature:Security Assistant","Team:Security Generative AI","v8.16.0"],"number":195480,"url":"https://github.com/elastic/kibana/pull/195480","mergeCommit":{"message":"[Security GenAI] Remove `assistantNaturalLanguageESQLTool` feature flag and enable by default (#195480)","sha":"3dd1ee8ae00a40b582f2d1f784c96269a1d2e016"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195480","number":195480,"mergeCommit":{"message":"[Security GenAI] Remove `assistantNaturalLanguageESQLTool` feature flag and enable by default (#195480)","sha":"3dd1ee8ae00a40b582f2d1f784c96269a1d2e016"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After several weeks of evaluation testing, we feel confident to switch from
ESQLKnowledgeBaseTooltoNaturalLanguageESQLToolas our default ESQL tool. This PR takes the following steps to do so:assistantNaturalLanguageESQLToolfeature flag and enables theNaturalLanguageESQLToolby defaultESQLKnowledgeBaseToolloadESQLfunction as we no longer use them with theNaturalLanguageESQLToolesql_existsfromisKnowledgeBaseSetupcheckesql/documentationandesql/language_definitionasNaturalLanguageESQLToolalready has these referencesesql/example_queriesas I am going to spike on including these in theNaturalLanguageESQLToolTo test
NaturalLanguageESQLToolhas been called.Free feel to run the ESQL Generation Regression Suite but I've already done it for you!
