Prune our usage of bootstrap #21186
Prune our usage of bootstrap #21186
Conversation
💔 Build Failed |
|
Jenkins, test this |
💚 Build Succeeded |
|
@cchaos There's no good way to test this other than clicking around a bit. The two places that had dom changes were the notify stuff (which I replaced with some EuiBadge classes)
And a small icon switchout (so we could remove bootstrap glyphicons) to font awesome Likely the biggest worry would be around removing normalize, but EUI has a very similar reset (which likely overwrote this one anyway) and I can't see any adverse effects. |
There was a problem hiding this comment.
I went through and did some whole folder searching for things that were removed and it looks all good to me. There was just one mistake in a FA switch.
Also, the badge you replaced used to swap it's number content for the words "stop" on hover but the new one doesn't. Maybe just add a "title" attribute?
| @@ -1,5 +1,5 @@ | |||
| <span ng-mouseleave="reset()" ng-keydown="onKeydown($event)" tabindex="0" role="slider" aria-valuemin="0" aria-valuemax="{{range.length}}" aria-valuenow="{{value}}"> | |||
| <i ng-repeat="r in range track by $index" ng-mouseenter="enter($index + 1)" ng-click="rate($index + 1)" class="glyphicon" ng-class="$index < value && (r.stateOn || 'glyphicon-star') || (r.stateOff || 'glyphicon-star-empty')"> | |||
| <i ng-repeat="r in range track by $index" ng-mouseenter="enter($index + 1)" ng-click="rate($index + 1)" class="fa" ng-class="$index < value && (r.stateOn || 'fa-star') || (r.stateOff || 'fa star-o')"> | |||
There was a problem hiding this comment.
fa star-o should be fa-star-o
| @import "labels.less"; | ||
| @import "badges.less"; | ||
| @import "jumbotron.less"; | ||
| @import "thumbnails.less"; |
There was a problem hiding this comment.
You might want to delete the actual file as well.
|
I also wouldn't worry about having removed the |
💚 Build Succeeded |
|
Feedback addressed. Tests pass. OK to merge @cchaos? |
snide
added
Team:Platform-Design
* remove bootstrap glyphicons * remove bootstrap scaffolding * prune type, remove code from bootstrap * remove bootstrap breadcrumb * remove normalize from bootstrap * remove thumbnail from bootstrap * remove jumbotron from bootstrap * remove wells from bootstrap * remove bootstrap badge
💔 Build Failed |
* remove bootstrap glyphicons * remove bootstrap scaffolding * prune type, remove code from bootstrap * remove bootstrap breadcrumb * remove normalize from bootstrap * remove thumbnail from bootstrap * remove jumbotron from bootstrap * remove wells from bootstrap * remove bootstrap badge
This PR removes as much vendored Bootstrap as possible from Kibana. Mostly it removes any bootstrap files / selectors we are not utilizing and if easy, provides some replacements for sections where we are using bootstrap.
This will not remove bootstrap completely. That will likely take another DOM pass.