Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Improved job validation messages. #21191

Merged
merged 2 commits into from
Jul 26, 2018

Conversation

walterra
Copy link
Contributor

Follow up to #21079. Improvements to job validation messages.

  • Changed cardinality_over_field_low "might be less suitable" to "might not be suitable".
  • Fixed documentation URLs.
  • Extended categorization_filters_invalid message + documentation URL.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lcawl
Copy link
Contributor

lcawl commented Jul 26, 2018

I've changed the links from X-Pack Reference links to Stack Overview links, since the latter contains information for 6.3 and later.

We might also have better links for the model limit messages when #21184 is merged.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@walterra walterra merged commit a121550 into elastic:master Jul 26, 2018
walterra added a commit to walterra/kibana that referenced this pull request Jul 26, 2018
Improvements to job validation messages:
- Changed cardinality_over_field_low "might be less suitable" to "might not be suitable".
- Fixed documentation URLs.
- Extended categorization_filters_invalid message + documentation URL.
walterra added a commit to walterra/kibana that referenced this pull request Jul 26, 2018
Improvements to job validation messages:
- Changed cardinality_over_field_low "might be less suitable" to "might not be suitable".
- Fixed documentation URLs.
- Extended categorization_filters_invalid message + documentation URL.
@walterra walterra deleted the ml-job-validation-message-wording-2 branch July 26, 2018 15:03
walterra added a commit that referenced this pull request Jul 27, 2018
Improvements to job validation messages:
- Changed cardinality_over_field_low "might be less suitable" to "might not be suitable".
- Fixed documentation URLs.
- Extended categorization_filters_invalid message + documentation URL.
walterra added a commit that referenced this pull request Jul 27, 2018
Improvements to job validation messages:
- Changed cardinality_over_field_low "might be less suitable" to "might not be suitable".
- Fixed documentation URLs.
- Extended categorization_filters_invalid message + documentation URL.
@lcawl lcawl added bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result labels Oct 29, 2018
@lcawl lcawl removed the bug Fixes for quality problems that affect the customer experience label Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Anomaly Detection ML anomaly detection :ml v6.4.0 v6.5.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants