[ML] Fixes enabled state of detector rule scope options #21263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
bug
|
Pinging @elastic/ml-ui |
walterra
reviewed
Jul 26, 2018
| if (scope !== undefined && Object.keys(scope).length > 0) { | ||
| isValid = true; | ||
| if (scope !== undefined) { | ||
| const enabledScope = Object.keys(scope).find(field => (scope[field].enabled === true)); |
There was a problem hiding this comment.
This could use .some(...) instead to be able to just evaluate against a boolean.
walterra
approved these changes
Jul 26, 2018
💚 Build Succeeded |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jul 26, 2018
* [ML] Fixes enabled state of detector rule scope options * [ML] Edit to rule scope enabled check following review
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jul 26, 2018
* [ML] Fixes enabled state of detector rule scope options * [ML] Edit to rule scope enabled check following review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the appearance of deselected scope options in the detector rule editor.
Previously options for partitioning fields which had not been selected for addition to the rule appeared with a greyed out disabled appearance, which could give the impression that they were not available for use:
This has been fixed so that the disabled style has been removed, and the checkbox next to each scope field just controls whether the field is added to the rule's scope and does not effect the enabled/disabled state of the controls:
Fixes #21208