Integrate main i18n tool into build pipeline

src/dev/run_extract_default_translations.js

@@ -17,13 +17,19 @@
  * under the License.
  */
 
+import chalk from 'chalk';
 import { run } from './run';
 import { extractDefaultTranslations } from './i18n/extract_default_translations';
 
 run(async ({ flags: { path, output, 'output-format': outputFormat } }) => {
-  await extractDefaultTranslations({
-    paths: Array.isArray(path) ? path : [path || './'],
-    output,
-    outputFormat,
-  });
+  try {
+    await extractDefaultTranslations({
+      paths: Array.isArray(path) ? path : [path || './'],
+      output,
+      outputFormat,
+    });
+  } catch (e) {
+    console.error(`${chalk.white.bgRed(' I18N ERROR ')} ${e.message || e}`);
+    process.exit(1);
+  }
 });

src/ui/ui_render/bootstrap/template.js.hbs

@@ -33,7 +33,7 @@ window.onload = function () {
       err.style['text-align'] = 'center';
       err.style['background'] = '#F44336';
       err.style['padding'] = '25px';
-      err.innerText = '{{i18n 'UI-WELCOME_ERROR' '{"defaultMessage": "Kibana did not load properly. Check the server output for more information."}'}}';
+      err.innerText = '{{i18n 'common.ui.welcomeError' '{"defaultMessage": "Kibana did not load properly. Check the server output for more information."}'}}';
 
       document.body.innerHTML = err.outerHTML;
     }

src/ui/ui_render/views/ui_app.pug

@@ -108,6 +108,6 @@ block content
       .kibanaWelcomeLogoCircle
         .kibanaWelcomeLogo
     .kibanaWelcomeText
-      | #{i18n('UI-WELCOME_MESSAGE', { defaultMessage: 'Loading Kibana' })}
+      | #{i18n('common.ui.welcomeMessage', { defaultMessage: 'Loading Kibana' })}
 
   script(src=bootstrapScriptUrl)

tasks/verify_translations.js

@@ -17,74 +17,30 @@
  * under the License.
  */
 
-// TODO: Integrate a new tool for translations checking
-// https://github.com/elastic/kibana/pull/19826
-import { i18nLoader } from '@kbn/i18n';
+const { resolve } = require('path');
 
-import { toArray } from 'rxjs/operators';
-import { fromRoot, formatListAsProse } from '../src/utils';
-import { findPluginSpecs } from '../src/plugin_discovery';
-import { collectUiExports } from '../src/ui';
-
-import * as i18nVerify from './utils/i18n_verify_keys';
-
-export default function (grunt) {
-  grunt.registerTask('verifyTranslations', async function () {
+module.exports = function (grunt) {
+  grunt.registerTask('verifyTranslations', function () {
     const done = this.async();
 
-    try {
-      const { spec$ } = findPluginSpecs({
-        env: 'production',
-        plugins: {
-          scanDirs: [fromRoot('src/core_plugins')]
+    const serverCmd = {
+      cmd: 'node',
+      args: [resolve(__dirname, '../scripts/extract_default_translations')],
+      opts: { stdio: 'inherit' },
+    };
+
+    new Promise((resolve, reject) => {
+      grunt.util.spawn(serverCmd, (error, result, code) => {
+        if (error || code !== 0) {
+          const error = new Error(`verifyTranslations exited with code ${code}`);
+          grunt.fail.fatal(error);
+          reject(error);
+          return;
         }
-      });
 
-      const specs = await spec$.pipe(toArray()).toPromise();
-      const uiExports = collectUiExports(specs);
-      await verifyTranslations(uiExports);
-
-      done();
-    } catch (error) {
-      done(error);
-    }
+        grunt.log.writeln(result);
+        resolve();
+      });
+    }).then(done, done);
   });
-
-}
-
-async function verifyTranslations(uiExports) {
-  const keysUsedInViews = [];
-
-  // Search files for used translation keys
-  const translationPatterns = [
-    { regexp: 'i18n\\(\'(.*)\'\\)',
-      parsePaths: [fromRoot('src/ui/ui_render/views/*.pug')] }
-  ];
-  for (const { regexp, parsePaths } of translationPatterns) {
-    const keys = await i18nVerify.getTranslationKeys(regexp, parsePaths);
-    for (const key of keys) {
-      keysUsedInViews.push(key);
-    }
-  }
-
-  // get all of the translations from uiExports
-  const translations = await i18nLoader.getAllTranslationsFromPaths(uiExports.translationPaths);
-  const keysWithoutTranslations = Object.entries(
-    i18nVerify.getNonTranslatedKeys(keysUsedInViews, translations)
-  );
-
-  if (!keysWithoutTranslations.length) {
-    return;
-  }
-
-  throw new Error(
-    '\n' +
-    '\n' +
-    'The following keys are used in angular/pug views but are not translated:\n' +
-    keysWithoutTranslations.map(([locale, keys]) => (
-      `   - ${locale}: ${formatListAsProse(keys)}`
-    )).join('\n') +
-    '\n' +
-    '\n'
-  );
-}
+};