added assertion for the email field in user creation #22604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmivkulkarni
added
Team:Security
💚 Build Succeeded |
|
I don't think this is testing what you intended. If I understand your change correctly, this is testing the user management screen, where we list all of the user accounts. The issue in question is the "current user" screen, where we fail to show the current user's email address: current behavior
expected behavior
|
rashmivkulkarni
changed the title
|
discussed with @legrego : this PR doesn't address the SDH ticket listed. But doesn't harm anything - just adds assertions to the email field while creating user. Will create a separate PR for addressing SDH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional assertions to email field while creating users