Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] [ML] Anomaly Explorer Charts jest tests. (#22759) #22796

Merged
merged 1 commit into from
Sep 7, 2018

Commits on Sep 7, 2018

  1. [ML] Anomaly Explorer Charts jest tests. (elastic#22759)

    After the migration to React in elastic#22622, this PR adds more test coverage based on jest to the Anomaly Explorer charts. This is done as preparation for some further refactoring (elastic#22626) and the integration of the support for charts for the rare detector (elastic#21163). The tests use mock data based on a standard multi-metric job using the farequote dataset.
    Besided the tests this PR includes the following changes:
    - In explore_series.js the path is no longer a concatenanted string but now using a template literal
    - The exploreSeries() function is no longer calling window.open by itself, it just returns the link
    because of the above, renamed exploreSeries() to getExploreSeriesLink() and moved it to chart_utils.js
    - explorer_charts_container_service.js is no longer requiring jQuery itself, it now receiving the required element as a factory argument. Further work on this is planned to get rid of jQuery.
    walterra committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    929e0d9 View commit details
    Browse the repository at this point in the history