Allow base path to be influenced by the current request #23367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
added
Team:Core
💚 Build Succeeded |
|
@spalger as requested, here's the |
|
I assigned myself to this in case @spalger doesn't get to it |
|
We should be able to close this out, as the spaces-phase-1 branch brought these changes along. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the extraction of the base path work required to enable Spaces.
This exposes two new functions on the HAPI request object:
getBasePath- Returns the concatanation ofserver.basePath+ the request specific basePath, if set. Otherwise, theserver.basePathis returned unmodified.setBasePath- Sets the request specific basePath. The value provided is concatenated with the server basepath to obtain the full base path for Kibana.