Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected naming for EuiInMemoryTable #34518

Closed
wants to merge 1 commit into from
Closed

Conversation

igoristic
Copy link
Contributor

@igoristic igoristic commented Apr 4, 2019

Summary

Fix for: #32663

Corrected the pagination naming convention used in EuiInMemoryTable.

This is still blocked by a pagination bug in eui: #1794

Temporary fix until: #1274 improvement is implemented

Checklist

For maintainers

@igoristic igoristic added the Team:Monitoring Stack Monitoring team label Apr 4, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@igoristic igoristic changed the title Corrected naming for EuiInMemoryTable Corrected naming for EuiInMemoryTable #32663 Apr 4, 2019
@igoristic igoristic changed the title Corrected naming for EuiInMemoryTable #32663 Corrected naming for EuiInMemoryTable Apr 4, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@chrisronline
Copy link
Contributor

Hey @igoristic,

I think I'm still seeing the behavior described in #32663. What steps should I follow to see the fix?

@igoristic igoristic closed this Apr 4, 2019
@igoristic igoristic deleted the pagination_fix branch April 4, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants