Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Kibana 7.3 Release Notes #41798

Merged
merged 8 commits into from
Jul 30, 2019
Merged

[DOCS] Kibana 7.3 Release Notes #41798

merged 8 commits into from
Jul 30, 2019

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Jul 23, 2019

Summary

Adds the Kibana 7.3 Release Notes.

[skip ci]

Checklist

  • Documentation was added for features that require explanation or tutorials

For a hosted version of the docs, see Kibana 7.3 Release Notes.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@KOTungseth KOTungseth added the release_note:skip Skip the PR/issue when compiling release notes label Jul 23, 2019
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@kobelb
Copy link
Contributor

kobelb commented Jul 26, 2019

There are a few notable PRs which are missing here which will be shipped in 7.3:

Two of them are missing a "Release Note" section in the issue, but the other one has that.

docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@rayafratkina
Copy link
Contributor

rayafratkina commented Jul 26, 2019

There are a few notable PRs which are missing here which will be shipped in 7.3:

Two of them are missing a "Release Note" section in the issue, but the other one has that.

@gchaps @KOTungseth It looks like we need to set start date earlier when running the script - the missing issues were committed in late May/early June, which is before the date we used to start search. I think we should start at FF of the release prior to the one we are working on. In this case it should have been 7.2 FF, which was 5/21.

It looks like we are missing a significant number of PRs... Perhaps it is worthwhile to rerun the script? If you use the version in https://github.com/elastic/github_report/pull/31, the names will be created correctly.

docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@alexfrancoeur
Copy link

@thomasneirynck @nreese it looks like some key PR's are missing from the release highlights. Do we not have them labeled appropriately? Specifically, the top features we have in 7.3 are missing.

Any others that should be there?

@KOTungseth
Copy link
Contributor Author

@rayafratkina @kobelb @alexfrancoeur I've rerun the script back to May 20th, which picked up a few of the missing PRs. The script was unable to pick up:

docs/CHANGELOG.asciidoc Show resolved Hide resolved
docs/CHANGELOG.asciidoc Show resolved Hide resolved
@thomasneirynck
Copy link
Contributor

@KOTungseth #36410 should not have had the release_note:skip label and should be included. I updated that PR with the correct labeling.

Can you still include this? Thanks!

Copy link
Contributor

@rayafratkina rayafratkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than comments already noted, LGTM

@KOTungseth KOTungseth merged commit cec4b75 into elastic:7.3 Jul 30, 2019
@KOTungseth KOTungseth deleted the docs/73-rn branch July 30, 2019 18:05
@KOTungseth KOTungseth removed the review label Jul 30, 2019
@KOTungseth
Copy link
Contributor Author

We are pausing the doc builds to prepare for the 7.3 release tomorrow, so I'm merging this PR now instead of tonight. If you have any other changes for the Release Notes, feel free to push additional PRs, or let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.3.0 v7.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants