[x-pack/ftr] refactor types to be more accurate/consistent with oss #42407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations |
spalger
added
the
release_note:skip
kobelb
reviewed
Jul 31, 2019
|
|
||
| const omitTypename = (key: string, value: keyof TimelineResult) => | ||
| key === '__typename' ? undefined : value; | ||
|
|
||
| const omitTypenameInTimeline = (timeline: TimelineResult) => | ||
| JSON.parse(JSON.stringify(timeline), omitTypename); | ||
|
|
||
| const createBasicTimeline = async (client: ApolloClient<InMemoryCache>, titleToSaved: string) => | ||
| const createBasicTimeline = async (client: ApolloClient<any>, titleToSaved: string) => |
There was a problem hiding this comment.
Can we not use ApolloCient<InMemoryCache> anymore?
There was a problem hiding this comment.
Because the function that makes it actually returns an ApolloClient<NormaliedCacheStore> or something like that, and I wasn't sure how to get that type, and this function doesn't actually cache what the store/cache type is.
|
This is so much cleaner! |
💚 Build Succeeded |
kobelb
approved these changes
Aug 1, 2019
…ack-ftr-provider-context # Conflicts: # x-pack/test/api_integration/apis/actions/delete.ts # x-pack/test/api_integration/apis/actions/find.ts # x-pack/test/api_integration/apis/actions/fire.ts # x-pack/test/api_integration/apis/actions/get.ts # x-pack/test/api_integration/apis/actions/update.ts # x-pack/test/api_integration/apis/alerting/alerts.ts # x-pack/test/api_integration/apis/alerting/update.ts # x-pack/test/api_integration/apis/infra/metadata.ts
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Aug 2, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
|
7.x/7.4: ffe8d77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the OSS and X-Pack functional tests more consistent in style, these changes update the x-pack tests to use the new
FtrProviderContextpattern.FtrProviderContextis a unique type created for each unique services/pageObject combination used by different functional test configs/projects.It types the argument passed to test/services/pageObject providers by the functional test runner and is created with the type:
ServiceProviderMapandPageObjectProviderMapare object types derived from theservicesandpageObjectsconfigs, which map names to providers. These maps are used to determine the types for thegetService()and thegetPageObjects()functions.The changes are pretty plentiful, but straightforward. Most locations were edited with pure find-replace, but a few places (like calls to
testSubjects.existOrFail()) were invalid once the proper types were put in place.