[Maps] use pre-indexed shapes in shape filters when shape is stored in elasticsearch #47171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
nickpeihl
approved these changes
Oct 3, 2019
|
Zoom-consistent filtering (for shapes anyway 😅) FTW! |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 3, 2019
…n elasticsearch (elastic#47171) * [Maps] use pre-indexed shapes in shape filters when shape is stored in elasticsearch * add _index to properties so it can be used in pre-indexed context * update TooltipControl snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of fix for #45521. Only geo_shape query supports quering by pre-indexed shapes and geo_shape query currently only works with geo_shape field mappings. This will not effect queries against geo_point fields until geo_shape query works for geo_points.
PR updates filtering by shape to use pre-indexed shape when available.
You will need 2 Kibana index patterns with geo_shape fields to test this PR. One index pattern to create the filter from and another index pattern to filter against.
To verify, create a filter for a feature. Edit the filter pill to view the filter. The filter should contain
indexed_shapeinstead ofshape.