Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] Show all SIEM ML Jobs in Anomaly Detection UI by default (#48067) #48361

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

spong
Copy link
Member

@spong spong commented Oct 16, 2019

Backports the following commits to 7.x:

…tic#48067)

## Summary

Resolves elastic#46874 by showing all SIEM ML Jobs in the Anomaly Detection UI by default -- no installation necessary! These changes also check for job compatibility using the ML API's `recognize` endpoint, and will display an alert message for those jobs that are not compatible. This also introduces the ability to filter by groups, and refactors/cleans up functions within this feature that were being used elsewhere in the app. Finally, there is improved error support in that errors are filtered to only the job the user is trying to install/enable instead of showing errors for the entire module.

##### Compatibility Callout
![image](https://user-images.githubusercontent.com/2946766/66734388-247c4980-ee20-11e9-8d5d-fa685fa3daf4.png)

##### Filter by Groups
![image](https://user-images.githubusercontent.com/2946766/66734663-36aab780-ee21-11e9-9685-9305e53f2263.png)



### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials -- will work with @benskelker on creating updated documentation.
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@spong spong added the backport label Oct 16, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spong spong merged commit e5ac41a into elastic:7.x Oct 16, 2019
@spong spong deleted the backport/7.x/pr-48067 branch October 16, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants