Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Canvas Shareable Runtime Download in Cloud #49538

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

clintandrewhall
Copy link
Contributor

Summary

After #48567 failed to fix #47405, and speaking with @kobelb, we're going to opt these Hapi URIs from resource confine restrictions. This has no impact on other paths, which I confirmed through debugging and console logging.

See: https://hapi.dev/family/inert/?v=5.2.2#hfilepath-options

Note the other paths are confined as before... the YO! { confine: false } request is the runtime request.

Uploading Screen Shot 2019-10-28 at 4.06.49 PM.png…

@clintandrewhall clintandrewhall added review loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v7.5.0 v7.6.0 labels Oct 28, 2019
@clintandrewhall clintandrewhall requested a review from a team as a code owner October 28, 2019 21:09
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloud][Canvas] Built asset removed in CI build
3 participants