Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registered applications to hide Kibana chrome #49795

Merged
merged 8 commits into from
Nov 13, 2019
Merged

Allow registered applications to hide Kibana chrome #49795

merged 8 commits into from
Nov 13, 2019

Commits on Nov 13, 2019

  1. Allow registered applications to hide Kibana chrome

    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    119fe3b View commit details
    Browse the repository at this point in the history

  2. Fix bug in flipped value of application chromeHidden

    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    81a195d View commit details
    Browse the repository at this point in the history

  3. Add additional test for app chrome hidden versus chrome visibility

    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    234afc1 View commit details
    Browse the repository at this point in the history

  4. Rename chromeHidden to chromeless

    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    523f43a View commit details
    Browse the repository at this point in the history

  5. Default chrome service app hidden observable to same value as force h… 

    …idden
    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    f51f996 View commit details
    Browse the repository at this point in the history

  6. Consolidate force hiding in chrome, add functional tests

    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    0242d1e View commit details
    Browse the repository at this point in the history

  7. Move chromeless flag to App interface to prevent legacy applications … 

    …from specifying
    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    43fdcf8 View commit details
    Browse the repository at this point in the history

  8. Address review nits to improve separation

    @eliperelman
    eliperelman committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    cec9714 View commit details
    Browse the repository at this point in the history