Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Remove react references from core Notifications apis (#49573) #50616

Merged
merged 2 commits into from
Nov 14, 2019

Commits on Nov 14, 2019

  1. Remove react references from core Notifications apis (elastic#49573)

    * add reactMount util to kibana_react
    
    (kibana-react) properly export reactMount
    
    * add MountPoint types and utility
    
    * adapt toast API to no longer accept react elements
    
    (toast API) properly export new Toast type
    
    * adapt calls by using reactMount
    
    createNotifications: do not wrap if text
    
    * update generated doc
    
    * add custom snapshot serializer for reactMount
    
    * fix unit tests
    
    fix xpack unit tests
    
    * adapt non-ts calls
    
    * do not add __reactMount__ property in production
    
    * remove string check on createNotifications
    
    * fix typo and small fix using obj spread
    
    * improve react mount snapshot serializer
    
    * simplify convertToEui
    
    * rename reactMount to toMountPoint
    
    * adapt newly added calls
    
    * move mount types to proper file
    
    * use new Mount types for OverlayBanner apis
    
    * fixing typo
    
    * adapt new calls
    
    * use destructured imports
    pgayvallet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    0323681 View commit details
    Browse the repository at this point in the history
  2. adapt call in 7.x

    pgayvallet committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    7c2ec5e View commit details
    Browse the repository at this point in the history