-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Migrate Uptime server routing to new platform #51125
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
793b424
Move a REST endpoint and the GQL endpoint to NP routing.
justinkambic b53f415
Delete obsolete REST endpoint.
justinkambic 1dfe5bb
Update remaining REST routes to work with NP router.
justinkambic 2129e50
Remove obsolete code, update some unit tests.
justinkambic b6da0f6
Simplify route creation.
justinkambic 98c7f39
Remove tests of API decommissioned API endpoint.
justinkambic 096eaf3
Rename domain check.
justinkambic 4337ec1
Make return shape of index pattern endpoint correspond to required NP…
justinkambic 2f85847
Move validate to appropriate level of route definition object for mon…
justinkambic 73efb70
Update snapshot count route.
justinkambic 441dece
Fix broken lint rule.
justinkambic 296c7b3
Remove usages of Boom.
justinkambic fb56268
Fix license router creation.
justinkambic e133bbf
Merge branch 'master' into uptime_np-routing
justinkambic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 0 additions & 56 deletions
56
x-pack/legacy/plugins/uptime/server/lib/adapters/auth/__tests__/xpack_auth_adapter.test.ts
This file was deleted.
Oops, something went wrong.
32 changes: 0 additions & 32 deletions
32
x-pack/legacy/plugins/uptime/server/lib/adapters/auth/adapter_types.ts
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
x-pack/legacy/plugins/uptime/server/lib/adapters/auth/index.ts
This file was deleted.
Oops, something went wrong.
40 changes: 0 additions & 40 deletions
40
x-pack/legacy/plugins/uptime/server/lib/adapters/auth/xpack_auth_adapter.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 0 additions & 9 deletions
9
x-pack/legacy/plugins/uptime/server/lib/domains/__tests__/__snapshots__/auth.test.ts.snap
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IRouter currently only provides per http method APIs to register routes.
Maybe we should something like
<T>route(method: <T extends RouteMethod>, registrar: RouteRegistrar<T>)
to address that kind of usages? It's pretty commun in router APIs.WDYT @restrry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were going to switch to this API in #44620 (comment)
Although we downgraded this issue priority since then. We can discuss if we want to implement this API earlier.