Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IndexPatternsSelector ⇒ NP #51620

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Nov 25, 2019

Summary

Move IndexPatternsSelector to NP
Replace import from ui/index_patterns with new platform imports

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

Replace import from ui/index_patterns with new platform imports
@lizozom lizozom requested a review from a team as a code owner November 25, 2019 16:50
@lizozom lizozom self-assigned this Nov 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom changed the title Move IndexPatternsSelector to NP Move IndexPatternsSelector ⇒ NP Nov 25, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@gospodarsky gospodarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 75d261d into elastic:master Nov 26, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Nov 26, 2019
* Move IndexPatternsSelector to NP
Replace import from ui/index_patterns with new platform imports

* karma mock

* added mock

* Fix jest tests
lizozom pushed a commit that referenced this pull request Nov 26, 2019
* Move IndexPatternsSelector to NP
Replace import from ui/index_patterns with new platform imports

* karma mock

* added mock

* Fix jest tests
timductive pushed a commit to timductive/kibana that referenced this pull request Dec 16, 2019
* Move IndexPatternsSelector to NP
Replace import from ui/index_patterns with new platform imports

* karma mock

* added mock

* Fix jest tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants