-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move IndexPatternsSelector ⇒ NP #51620
Merged
lizozom
merged 6 commits into
elastic:master
from
lizozom:newplatform/data-plugin/index-pattern/index-pattern-select
Nov 26, 2019
Merged
Move IndexPatternsSelector ⇒ NP #51620
lizozom
merged 6 commits into
elastic:master
from
lizozom:newplatform/data-plugin/index-pattern/index-pattern-select
Nov 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace import from ui/index_patterns with new platform imports
lizozom
added
Feature:NP Migration
release_note:skip
Skip the PR/issue when compiling release notes
Team:AppArch
v7.6.0
v8.0.0
labels
Nov 25, 2019
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
changed the title
Move IndexPatternsSelector to NP
Move IndexPatternsSelector ⇒ NP
Nov 25, 2019
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
…plugin/index-pattern/index-pattern-select
gospodarsky
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
…plugin/index-pattern/index-pattern-select
Dosant
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes LGTM
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Nov 26, 2019
* Move IndexPatternsSelector to NP Replace import from ui/index_patterns with new platform imports * karma mock * added mock * Fix jest tests
lizozom
pushed a commit
that referenced
this pull request
Nov 26, 2019
timductive
pushed a commit
to timductive/kibana
that referenced
this pull request
Dec 16, 2019
* Move IndexPatternsSelector to NP Replace import from ui/index_patterns with new platform imports * karma mock * added mock * Fix jest tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
IndexPatternsSelector
to NPReplace import from ui/index_patterns with new platform imports
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers