[EPM] Remove encoding of Kibana objects as not needed anymore #51694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With elastic/package-registry#157 issue elastic/package-registry#42 has been resolved. This means the code to encode some of the Kibana fields is not needed anymore.
ruflin
added
the
Feature:EPM
|
Pinging @elastic/epm (Feature:EPM) |
💚 Build Succeeded |
jfsiii
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
LGTM. I checked it out locally then ran:
curl --user elastic:changeme localhost:5601/api/epm/install/iptables-1.0.4
curl --user elastic:changeme localhost:5601/api/epm/install/coredns-1.0.1Both returned the expected values in the response. The saved objects were shown in the management section of Kibana. I tried dashboard from each and they did the best you could expect. They laid out the dashboard and tried to load the data which failed because there wasn't any or it was missing an index, etc.
curl --user elastic:changeme localhost:5601/api/epm/delete/iptables-1.0.4
curl --user elastic:changeme localhost:5601/api/epm/delete/coredns-1.0.1also both returned the expected values and removed the entries from Saved Objects in the Management section
jen-huang
added
the
Team:Fleet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With elastic/package-registry#157 issue elastic/package-registry#42 has been resolved. This means the code to encode some of the Kibana fields is not needed anymore.