vis_type_timeseries server side new platform migration #52501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor some Framework level deps
Kerry350
added
release_note:skip
jasonrhodes
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
LGTM, legacy server registration is still a little hard to follow but moving init directly into the register legacy API method makes it much much easier than the observable flow before, and I'm not sure we can do better until things are migrated. Thanks so much for taking this on!!!
jasonrhodes
reviewed
Dec 19, 2019
| @@ -25,7 +25,7 @@ describe('getEsShardTimeout', () => { | |||
| const req = { | |||
| getEsShardTimeout: async () => { | |||
| return 12345; | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
I know right...dunno why it didn't tell me in the first place 🤔
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Dec 19, 2019
Kerry350
added a commit
that referenced
this pull request
Dec 19, 2019
jasonrhodes
pushed a commit
to jasonrhodes/kibana
that referenced
this pull request
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP of the migration of thevis_type_timeseriesplugin to the new platform, on the server side.This is a server side migration of the
vis_type_timeseriesplugin to the new platform. It migrates what was needed for the Logs and Metrics dependencies.What's covered?
vis_type_timeseriesplugin now has a New Platform plugin, within thesrc/pluginsdirectory.getVisDataas part of it's public contract to other plugins within thesetup()method.vis_type_timeseries("metrics") plugin, with all hacks / workarounds removed. Infra was the only plugin I could find using thegetVisDatafunction in a plugin <-> plugin capacity.getVisDatafunction has a facade added at the top level to augment an object to look like the oldreqit required, but using the newrequestContextandrequestfrom the New Platform router. This was to make refactoring easier at this stage, there are no TypeScript types to aid in changing this code, so changing many layers of code seemed brittle./api/metrics/vis/dataAPI endpoint has been fully migrated to the NP router. This is the endpoint things like Kibana's Visualize uses.What's not covered?
___LEGACY.server.