-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] gather field formatters in data request #53311
Conversation
…nc in vector_style
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some suggestions in the comments.
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, but using lambda-notation add noise imho, consider removing
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
@@ -334,6 +337,37 @@ export class VectorStyle extends AbstractStyle { | |||
return fieldMeta ? fieldMeta : fieldMetaFromLocalFeatures; | |||
}; | |||
|
|||
_getFieldFormatter = fieldName => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar imho. make this part of the type _getFieldFormatter(fieldName){
retest |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* [Maps] gather field formatters in data request so they can be used sync in vector_style * review feedback * hasMatchingMetricField * review feedback * fix typo in function name
This PR uses data request to gather field formatters so they can be accessed synchronously during data preparation phase. This will be required with text labels since setFeatureState must stay synchronous and field formatters are now needed in that method.
decouples #52957 and #53173