Reduce license plugin api #53489
Merged
Reduce license plugin api #53489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Feature:New Platform
release_note:plugin_api_changes
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
commented
Dec 18, 2019
| @@ -8,31 +8,31 @@ import { ILicense } from '../../../../../../../plugins/licensing/server'; | |||
| import { licenseCheck } from '../license'; | |||
|
|
|||
| describe('license check', () => { | |||
| let mockLicense: Pick<ILicense, 'isActive' | 'isOneOf'>; | |||
| let mockLicense: Pick<ILicense, 'isActive' | 'hasAtLeast'>; | |||
There was a problem hiding this comment.
@justinkambic looks like we should update CODEOWNERS to make uptime owner of the plugin
joshdover
approved these changes
Dec 18, 2019
legrego
reviewed
Dec 18, 2019
Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>
Co-Authored-By: Josh Dover <me@joshdover.com>
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Dec 19, 2019
* inOneOf --> hasAtLeast. to follow to licensing hierarchical model * adopt licensing tests * add license mock and use it in the tests * adopt security plugin to hasAtLeast and licensing mocks * adopt uptime to hasAtLeast * update readme * add test for unknown license * fix import in js test * fix security plugin merge conflict * Update x-pack/plugins/security/common/licensing/license_service.ts Co-Authored-By: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/licensing/common/types.ts Co-Authored-By: Josh Dover <me@joshdover.com> * simplify tests * remove unused import
mshustov
added a commit
that referenced
this pull request
Dec 19, 2019
* inOneOf --> hasAtLeast. to follow to licensing hierarchical model * adopt licensing tests * add license mock and use it in the tests * adopt security plugin to hasAtLeast and licensing mocks * adopt uptime to hasAtLeast * update readme * add test for unknown license * fix import in js test * fix security plugin merge conflict * Update x-pack/plugins/security/common/licensing/license_service.ts Co-Authored-By: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/licensing/common/types.ts Co-Authored-By: Josh Dover <me@joshdover.com> * simplify tests * remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduces license API surface: isBasic, isNotBasic, isOneOf are superseded by
hasAtLeastas it reflects the hierarchical nature of the stack licenses.Adds License mocks.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev docs
License method
isOneOfwas superseded byhasAtLeastthat checks the current license is not less than passes minimal required license.