Infra Server Migration #53955
Closed
Infra Server Migration #53955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsiii
reviewed
Jan 3, 2020
x-pack/plugins/infra/server/lib/adapters/log_entries/kibana_log_entries_adapter.ts
Outdated
Show resolved
Hide resolved
Kerry350
reviewed
Jan 6, 2020
| indexPatterns: { | ||
| indexPatternsServiceFactory: legacyServer.indexPatternsServiceFactory, | ||
| // NP_TODO: How do we move this to new platform? | ||
| legacyServer.addAppLinksToSampleDataset('logs', [ |
There was a problem hiding this comment.
I think something may have potentially gone wrong with a merge somewhere along the line, and the migration from legacyServer.addAppLinksToSampleDataset to plugins.home.sampleData.addAppLinksToSampleDataset in #52753.
We can remove legacyServer.addAppLinksToSampleDataset (it doesn't exist in master).
(This file is also throwing an exception as logsSampleDataLinkLabel doesn't exist here).
|
|
||
| plugins.features.registerFeature(METRICS_FEATURE); | ||
| plugins.features.registerFeature(LOGS_FEATURE); | ||
|
|
There was a problem hiding this comment.
The call to the home plugin doesn't exist here as it does within the new_platform_plugin.ts file, e.g.:
plugins.home.sampleData.addAppLinksToSampleDataset('logs', [
{
path: `/app/${APP_ID}#/logs`,
label: logsSampleDataLinkLabel,
icon: 'logsApp',
},
]);
Co-Authored-By: John Schulz <github.com@jfsiii.org>
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
|
Closing in favour of #54583 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP draft PR, may not be mergeable bc we moved a lot of files that others may be working on in other branches. Will need to heavily coordinate with @elastic/logs-metrics-ui team.
Probably easier to step through this commit by commit to see the changes.