Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate using elasticsearch.ssl.certificate without elasticsearch.ssl.key and vice versa #54392

Merged
merged 8 commits into from
Jan 11, 2020
Merged

Deprecate using elasticsearch.ssl.certificate without elasticsearch.ssl.key and vice versa #54392

merged 8 commits into from
Jan 11, 2020

Commits on Jan 9, 2020

  1. Migrate ElasticsearchConfig deprecation out of Core deprecations

    @jportner
    jportner committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    b8fd76d View commit details
    Browse the repository at this point in the history

  2. Add ElasticsearchConfig SSL deprecations

    @jportner
    jportner committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    a19698a View commit details
    Browse the repository at this point in the history

  3. Remove logger from ElasticsearchConfig 

    This was used to log warnings messages. We have decided to
deprecate the config settings instead of just logging warnings. So
ElasticsearchConfig doesn't need to have a logger at all anymore.
    @jportner
    jportner committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    906c100 View commit details
    Browse the repository at this point in the history

  4. node scripts/check_core_api_changes.js --accept

    @jportner
    jportner committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    7c247ef View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into elasticsearch-config-deprecations

    @jportner
    jportner committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    f5e8de0 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Merge branch 'master' into elasticsearch-config-deprecations

    @jportner
    jportner committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    956a475 View commit details
    Browse the repository at this point in the history

  2. Changed keystore parse error to be more strict 

    The Elasticsearch config should error out if a PKCS12 keystore
does not contain a key *or* a certificate. This was intended to be
the functionality in PR elastic#53810, but it was overlooked. Changing it
now since this PR is changing code in the same file.
    @jportner
    jportner committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    75d0f70 View commit details
    Browse the repository at this point in the history

  3. Address PR review feedback 

    Check for key existence, not key truthiness.
    @jportner
    jportner committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    3120c8f View commit details
    Browse the repository at this point in the history