Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Floating tooltip needs to take page offset into account #54567

Merged
merged 2 commits into from
Jan 14, 2020
Merged

[Console] Floating tooltip needs to take page offset into account #54567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718a975
Take page offset into account too
jloleysens Jan 13, 2020
f35a535
Merge branch 'master' of github.com:elastic/kibana into fix/console/p…
jloleysens Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ugins/console/public/np_ready/application/models/legacy_core_editor/legacy_core_editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,9 @@ export class LegacyCoreEditor implements CoreEditor {
const maxLineLength = this.getWrapLimit() - 5;
const isWrapping = firstLine.length > maxLineLength;
const getScreenCoords = (line: number) =>
this.editor.renderer.textToScreenCoordinates(line - 1, startColumn).pageY - offsetFromPage;
this.editor.renderer.textToScreenCoordinates(line - 1, startColumn).pageY -
offsetFromPage +
(window.pageYOffset || 0);
const topOfReq = getScreenCoords(startLine);

if (topOfReq >= 0) {
Expand Down