Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Removes dashboard search batching setting #54594

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented Jan 13, 2020

Summary

This PR adds a deprecation notice to the dashboard batch searches setting from the Advanced Settings doc.

Screen Shot 2020-01-13 at 8 58 50 AM

[skip ci]

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 13, 2020
@gchaps gchaps requested a review from lizozom January 13, 2020 16:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
However it's deprecated from 7.6.
I was asked not to backport this into 7.5.

@@ -187,7 +187,8 @@ Refresh the page to apply the changes.
=== Search settings

[horizontal]
`courier:batchSearches`:: When disabled, dashboard panels will load individually, and search requests will terminate when
`courier:batchSearches`:: **Deprecated as of 7.5.0. Starting in 8.0, this setting will be optimized internally.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.6.0

@gchaps gchaps merged commit f7ba362 into elastic:master Jan 13, 2020
@gchaps gchaps deleted the docs/dashboard-search-batching branch January 13, 2020 18:19
gchaps added a commit to gchaps/kibana that referenced this pull request Jan 13, 2020
* [DOCS] Removes dashboard search batching setting

* [DOCS] Keeps content for search setting and adds deprecation notice

* [DOCS] Fixes version notice in deprecation notice
gchaps added a commit that referenced this pull request Jan 13, 2020
* [DOCS] Removes dashboard search batching setting

* [DOCS] Keeps content for search setting and adds deprecation notice

* [DOCS] Fixes version notice in deprecation notice
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
* [DOCS] Removes dashboard search batching setting

* [DOCS] Keeps content for search setting and adds deprecation notice

* [DOCS] Fixes version notice in deprecation notice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants