-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Removes dashboard search batching setting #54594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchaps
added
Team:Docs
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jan 13, 2020
Pinging @elastic/kibana-docs (Team:Docs) |
7 tasks
lizozom
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
However it's deprecated from 7.6.
I was asked not to backport this into 7.5.
lizozom
reviewed
Jan 13, 2020
@@ -187,7 +187,8 @@ Refresh the page to apply the changes. | |||
=== Search settings | |||
|
|||
[horizontal] | |||
`courier:batchSearches`:: When disabled, dashboard panels will load individually, and search requests will terminate when | |||
`courier:batchSearches`:: **Deprecated as of 7.5.0. Starting in 8.0, this setting will be optimized internally.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7.6.0
gchaps
added a commit
to gchaps/kibana
that referenced
this pull request
Jan 13, 2020
* [DOCS] Removes dashboard search batching setting * [DOCS] Keeps content for search setting and adds deprecation notice * [DOCS] Fixes version notice in deprecation notice
gchaps
added a commit
that referenced
this pull request
Jan 13, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* [DOCS] Removes dashboard search batching setting * [DOCS] Keeps content for search setting and adds deprecation notice * [DOCS] Fixes version notice in deprecation notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a deprecation notice to the dashboard batch searches setting from the Advanced Settings doc.
[skip ci]