[Uptime] Fix flaky uptime overview page test #54767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
blocker
failed-test
|
Pinging @elastic/uptime (Team:uptime) |
|
Pinging @elastic/kibana-test-triage (failed-test) |
justinkambic
added
release_note:fix
release_note:skip
nreese
reviewed
Jan 14, 2020
| @@ -51,8 +51,14 @@ export function UptimePageProvider({ getPageObjects, getService }: FtrProviderCo | |||
| await Promise.all(monitorIdsToCheck.map(id => uptimeService.monitorPageLinkExists(id))); | |||
| } | |||
|
|
|||
| public async pageUrlContains(value: string) { | |||
| return await uptimeService.urlContains(value); | |||
| public async pageUrlContains(value: string, expected: boolean = true, timeout: number = 2000) { | |||
There was a problem hiding this comment.
The common pattern for retires like this are to use retry.try. This will keep trying a couple of times until the expression does not throw.
await retry.try(async () => {
const isChromeHidden = await PageObjects.common.isChromeHidden();
expect(isChromeHidden).to.be(true);
});
nreese
approved these changes
Jan 14, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 21, 2020
* Fix flaky uptime overview page test. * Increase timeout for url checks. * Prefer standard `retry.try` to custom retry implementation. * Remove unneeded symbol. * Remove unnecessary type annotation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 21, 2020
* Fix flaky uptime overview page test. * Increase timeout for url checks. * Prefer standard `retry.try` to custom retry implementation. * Remove unneeded symbol. * Remove unnecessary type annotation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
that referenced
this pull request
Jan 21, 2020
* Fix flaky uptime overview page test. * Increase timeout for url checks. * Prefer standard `retry.try` to custom retry implementation. * Remove unneeded symbol. * Remove unnecessary type annotation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
that referenced
this pull request
Jan 21, 2020
* Fix flaky uptime overview page test. * Increase timeout for url checks. * Prefer standard `retry.try` to custom retry implementation. * Remove unneeded symbol. * Remove unnecessary type annotation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
Backported to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #54541.
The reason this test was failing was due to our test checking the URL before it had been updated. This usually happens really fast, so it passes most of the time. This patch adds a timeout to the function responsible for checking the URL state between page and filter updates so we will only fail after
2000ms, which is about 10x the duration of the check.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers