Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateful TopNavMenu improvement #56984

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/data/public/ui/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export { SuggestionsComponent } from './typeahead/suggestions_component';
export { IndexPatternSelect } from './index_pattern_select';
export { FilterBar } from './filter_bar';
export { QueryStringInput } from './query_string_input/query_string_input';
export { SearchBar, SearchBarProps } from './search_bar';
export { SearchBar, SearchBarProps, StatefulSearchBarProps } from './search_bar';

// @internal
export {
Expand Down
4 changes: 4 additions & 0 deletions src/plugins/data/public/ui/search_bar/create_search_bar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ export function createSearchBar({ core, storage, data }: StatefulSearchBarDeps)
filterManager: data.query.filterManager,
});
const { timeRange, refreshInterval } = useTimefilter({
dateRangeFrom: props.dateRangeFrom,
dateRangeTo: props.dateRangeTo,
refreshInterval: props.refreshInterval,
isRefreshPaused: props.isRefreshPaused,
timefilter: data.query.timefilter.timefilter,
});

Expand Down
1 change: 1 addition & 0 deletions src/plugins/data/public/ui/search_bar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@
*/

export { SearchBar, SearchBarProps } from './search_bar';
export { StatefulSearchBarProps } from './create_search_bar';
18 changes: 15 additions & 3 deletions src/plugins/data/public/ui/search_bar/lib/use_timefilter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,27 @@

import { useState, useEffect } from 'react';
import { Subscription } from 'rxjs';
import { DataPublicPluginStart } from 'src/plugins/data/public';
import { DataPublicPluginStart, TimeRange, RefreshInterval } from 'src/plugins/data/public';

interface UseTimefilterProps {
dateRangeFrom?: string;
dateRangeTo?: string;
refreshInterval?: number;
isRefreshPaused?: boolean;
timefilter: DataPublicPluginStart['query']['timefilter']['timefilter'];
}

export const useTimefilter = (props: UseTimefilterProps) => {
const [timeRange, setTimerange] = useState(props.timefilter.getTime());
const [refreshInterval, setRefreshInterval] = useState(props.timefilter.getRefreshInterval());
const initialTimeRange: TimeRange = {
from: props.dateRangeFrom || props.timefilter.getTime().from,
to: props.dateRangeTo || props.timefilter.getTime().to,
};
const initialRefreshInterval: RefreshInterval = {
value: props.refreshInterval || props.timefilter.getRefreshInterval().value,
pause: props.isRefreshPaused || props.timefilter.getRefreshInterval().pause,
};
const [timeRange, setTimerange] = useState(initialTimeRange);
const [refreshInterval, setRefreshInterval] = useState(initialRefreshInterval);

useEffect(() => {
const subscriptions = new Subscription();
Expand Down
10 changes: 5 additions & 5 deletions src/plugins/data/public/ui/search_bar/search_bar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,8 @@ interface SearchBarInjectedDeps {
timeHistory: TimeHistoryContract;
// Filter bar
onFiltersUpdated?: (filters: esFilters.Filter[]) => void;
// Date picker
dateRangeFrom?: string;
dateRangeTo?: string;
// Autorefresh
onRefreshChange?: (options: { isPaused: boolean; refreshInterval: number }) => void;
isRefreshPaused?: boolean;
refreshInterval?: number;
}

export interface SearchBarOwnProps {
Expand All @@ -69,6 +64,11 @@ export interface SearchBarOwnProps {
showDatePicker?: boolean;
showAutoRefreshOnly?: boolean;
filters?: esFilters.Filter[];
// Date picker
isRefreshPaused?: boolean;
refreshInterval?: number;
dateRangeFrom?: string;
dateRangeTo?: string;
// Query bar - should be in SearchBarInjectedDeps
query?: Query;
// Show when user has privileges to save
Expand Down
14 changes: 1 addition & 13 deletions src/plugins/navigation/public/top_nav_menu/top_nav_menu.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ import { TopNavMenu } from './top_nav_menu';
import { TopNavMenuData } from './top_nav_menu_data';
import { shallowWithIntl } from 'test_utils/enzyme_helpers';

const mockTimeHistory = {
add: () => {},
get: () => {
return [];
},
};

const dataShim = {
ui: {
SearchBar: () => <div className="searchBar" />,
Expand Down Expand Up @@ -76,12 +69,7 @@ describe('TopNavMenu', () => {

it('Should render search bar', () => {
const component = shallowWithIntl(
<TopNavMenu
appName={'test'}
showSearchBar={true}
timeHistory={mockTimeHistory}
data={dataShim as any}
/>
<TopNavMenu appName={'test'} showSearchBar={true} data={dataShim as any} />
);

expect(component.find(TOP_NAV_ITEM_SELECTOR).length).toBe(0);
Expand Down
5 changes: 2 additions & 3 deletions src/plugins/navigation/public/top_nav_menu/top_nav_menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ import { I18nProvider } from '@kbn/i18n/react';

import { TopNavMenuData } from './top_nav_menu_data';
import { TopNavMenuItem } from './top_nav_menu_item';
import { SearchBarProps, DataPublicPluginStart } from '../../../data/public';
import { StatefulSearchBarProps, DataPublicPluginStart } from '../../../data/public';

export type TopNavMenuProps = Partial<SearchBarProps> & {
appName: string;
export type TopNavMenuProps = StatefulSearchBarProps & {
config?: TopNavMenuData[];
showSearchBar?: boolean;
data?: DataPublicPluginStart;
Expand Down