Index pattern management - typescript components #56987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
…ttkime/kibana into create_index_pattern_components_to_ts
|
@elasticmachine merge upstream |
…ttkime/kibana into create_index_pattern_components_to_ts
streamich
added
Feature:Data Views
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
…ttkime/kibana into create_index_pattern_components_to_ts
…ith the same name
mattkime
added
the
release_note:skip
|
@elasticmachine merge upstream |
streamich
approved these changes
Feb 18, 2020
Comment on lines
45
to
52
| }: { | ||
| isInputInvalid: boolean; | ||
| errors: any; | ||
| characterList: string; | ||
| query: string; | ||
| onQueryChanged: (e: React.ChangeEvent<HTMLInputElement>) => void; | ||
| goToNextStep: (query: string) => void; | ||
| isNextStepDisabled: boolean; |
There was a problem hiding this comment.
Maybe instead of inlining a type here, type this function as a React component?
interface Props {
isInputInvalid: boolean;
errors: any;
characterList: string;
query: string;
onQueryChanged: (e: React.ChangeEvent<HTMLInputElement>) => void;
goToNextStep: (query: string) => void;
isNextStepDisabled: boolean;
}
const Header: React.FC<Props> = | @@ -22,16 +22,26 @@ import React from 'react'; | |||
| import { EuiText, EuiTextColor, EuiIcon } from '@elastic/eui'; | |||
|
|
|||
| import { FormattedMessage } from '@kbn/i18n/react'; | |||
| import { MatchedIndex } from '../../../../types'; | |||
|
|
|||
| export const StatusMessage = ({ | |||
There was a problem hiding this comment.
Same with this component.
| @@ -29,6 +29,11 @@ export const AdvancedOptions = ({ | |||
| indexPatternId, | |||
| toggleAdvancedOptions, | |||
| onChangeIndexPatternId, | |||
| }: { | |||
| @@ -23,7 +23,13 @@ import { EuiTitle, EuiSpacer, EuiText } from '@elastic/eui'; | |||
|
|
|||
| import { FormattedMessage } from '@kbn/i18n/react'; | |||
|
|
|||
| export const Header = ({ indexPattern, indexPatternName }) => ( | |||
| export const Header = ({ | |||
| @@ -42,6 +42,13 @@ export const TimeField = ({ | |||
| isLoading, | |||
| selectedTimeField, | |||
| onTimeFieldChanged, | |||
| }: { | |||
…ttkime/kibana into create_index_pattern_components_to_ts
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Feb 18, 2020
* Index pattern management - typescript components
mattkime
added a commit
that referenced
this pull request
Feb 18, 2020
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Index pattern management - typescript components