Load alert on delete with a fallback instead of doubling the calls (ESO + SOC calls) #57004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
review
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
|
@elaslticmachine merge upstream |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Feb 6, 2020
mikecote
added a commit
that referenced
this pull request
Feb 6, 2020
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the delete API follow up portion of #56619.
This PR resolves the conversation previously had with @pmuellr in regards to avoiding loading the saved object twice when most cases only one call will work. Ref: #56543 (comment).
In the previous PR, when deleting an alert, the system would load the alert via ESO plugin and via SOC at the same time. It would then disregard the result from ESO if ever it threw an error. The changes now rely on ESO working (without broken AAD) but will fallback to SOC.
Definitions
ESO = Encrypted Saved Objects
SOC = Saved Objects Client