Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Detection Engine] Reject if duplicate rule_id in request payload #57057

Merged
merged 10 commits into from
Feb 13, 2020
Merged

[SIEM] [Detection Engine] Reject if duplicate rule_id in request payload #57057

merged 10 commits into from
Feb 13, 2020

Commits on Feb 7, 2020

  1. prevents creation of rules when duplicate rule_id is present

    @dhurley14
    dhurley14 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    fce198c View commit details
    Browse the repository at this point in the history

  2. adds unit test to reflect change

    @dhurley14
    dhurley14 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    7000f8b View commit details
    Browse the repository at this point in the history

  3. genericizes duplicate discovery functions, allows creation of non-dup… 

    …licated rules even when duplicates are discovered, keeps same return type signature, updates relevant test for duplicates in request payload
    @dhurley14
    dhurley14 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    59df66d View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2020

  1. Merge branch 'master' into check-for-dupes-on-bulk

    @elasticmachine
    elasticmachine authored Feb 8, 2020
    Configuration menu
    Copy the full SHA
    f00a7c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. utilizes countBy and removes reduce in favor of a filter on getDuplic… 

    …ates function
    @dhurley14
    dhurley14 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    64390df View commit details
    Browse the repository at this point in the history

  2. fix type

    @dhurley14
    dhurley14 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    ee37882 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Merge branch 'master' into check-for-dupes-on-bulk

    @elasticmachine
    elasticmachine authored Feb 12, 2020
    Configuration menu
    Copy the full SHA
    b58e9d6 View commit details
    Browse the repository at this point in the history

  2. removes skip from e2e test for duplicates on bulk create, updates exp… 

    …ected response in e2e test, fixes bug where duplicated error messages appeared for each instance of a duplicated rule_id (found this one through the e2e tests)! Adds unit test to catch this case.
    @dhurley14
    dhurley14 committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    e2609c1 View commit details
    Browse the repository at this point in the history

  3. getDuplicate returns empty array instead of null, removes unnecessary… 

    … return logic
    @dhurley14
    dhurley14 committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    ad56892 View commit details
    Browse the repository at this point in the history

  4. removes null coalescing from includes in filter

    @dhurley14
    dhurley14 committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    23c459e View commit details
    Browse the repository at this point in the history