Embeddable add panel examples #57319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
added
Feature:Embedding
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
stacey-gammon
force-pushed
the
2020-02-07-embed-explorer-more-examples
branch
2 times, most recently
from
fcb8e44
to
3fa97d0
Compare
stacey-gammon
force-pushed
the
2020-02-07-embed-explorer-more-examples
branch
from
3fa97d0
to
04a3590
Compare
|
@elasticmachine merge upstream |
…bed-explorer-more-examples
streamich
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
LGTM. For some reason GitHub did not allow me to add comments inline, so here they are:
- typo: "Wednesdays".
- typo: "encylopedia" 👉"encyclopedia".
- nit: before
setEmbeddable(e);you need to check if component is still mounted, but given that this is an example—does not really matter.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Feb 19, 2020
* Embeddable add panel examples * add tests * Fix type error after merge * address code review comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
stacey-gammon
added a commit
that referenced
this pull request
Feb 19, 2020
* Embeddable add panel examples * add tests * Fix type error after merge * address code review comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 20, 2020
* master: (136 commits) [Visualize] Remove legacy appState in visualize (elastic#57330) Use static time for tsvb rollup test (elastic#57701) [SIEM] Fix ResizeObserver polyfill (elastic#58046) [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id skip flaky suite (elastic#56816) skip flaky suite (elastic#58059) skip flaky suite (elastic#45348) migrates notification server routes to NP (elastic#57906) Moved all of the show/hide toggles outside of ordered lists. (elastic#57163) [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532) [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055) Embeddable add panel examples (elastic#57319) Fix useRequest to support query change (elastic#57723) Allow custom paths in plugin generator (elastic#57766) [SIEM][Case] Merge header components (elastic#57816) [ML] New Platform server shim: update job audit messages routes (elastic#57925) [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945) [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934) Upgrade yargs (elastic#57720) skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998) ... # Conflicts: # src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap # src/plugins/advanced_settings/public/management_app/components/field/field.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more examples to the embeddable explorer for dynamically adding embeddables to a container and how to ask the user for data required by the embeddable but not supplied by the container.