Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move canvas to use NP Expressions service #58387

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Move canvas to use NP Expressions service #58387

merged 3 commits into from
Mar 10, 2020

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Feb 24, 2020

Summary

This updates Canvas to use the Expressions plugin instead of the legacy interpreter plugin.

Some important points that come along with this

  • Defines an api interface that is exported as part of Canvas Setup. This is the defined api that other plugins will have to use to register functionality with canvas.
  • Adds Legacy Plugin support. This allows existing 3rd party plugins to continue working as they always have, but everything is being registered through the interface under the hood
  • canvas_plugin_src is booting up like an additional plugin, using the exported interface to do all of it's registration.

@crob611 crob611 added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Feb 24, 2020
@crob611 crob611 requested review from a team as code owners February 24, 2020 18:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

streamich
streamich reviewed Feb 24, 2020
View reviewed changes
x-pack/legacy/plugins/canvas/public/legacy_plugin_support.ts
Comment on lines +44 to +47
(global as any).kbnInterpreter = Object.assign(
(global as any).kbnInterpreter || {},
registryFactory(legacyRegistries)
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppisljar FYI (we were just looking at a similar code in legacy Interpreter plugin).

streamich
streamich approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

packages/kbn-interpreter/src/common/lib/get_type.d.ts
* under the License.
*/

export declare function getType(node: any): string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add re-export

export { getType } from '../common';

to src/plugins/expressions/public/index.ts, and then import that getType function from the expressions plugin.

poffdeluxe
poffdeluxe approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@crob611
Copy link
Contributor Author

crob611 commented Mar 6, 2020

@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Mar 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit e982bed into elastic:master Mar 10, 2020
crob611 pushed a commit to crob611/kibana that referenced this pull request Mar 10, 2020
@elasticmachine
Move canvas to use NP Expressions service (elastic#58387)
5d410ed 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@crob611 crob611 mentioned this pull request Mar 10, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
dd5ae27 
* master:
  Add a retry to dashboard test for a sometimes slow async operation (elastic#59600)
  [Endpoint] Sample data generator for endpoint app (elastic#58936)
  [Vis Editor] Refactoring metrics axes (elastic#59135)
  [DOCS] Changed Discover app to Discover (elastic#59769)
  [Metrics Alerts] Add support for search query and groupBy on alerts (elastic#59388)
  Enhancement - EUICodeEditor for Visualize JSON  (elastic#58679)
  [ML] Transforms: Data grid fixes. (elastic#59538)
  [SIEM] Fix and consolidate handling of error responses in the client (elastic#59438)
  [Maps] convert tooltip classes to typescript (elastic#59589)
  [ML] Functional tests - re-activate date_nanos test (elastic#59649)
  Move canvas to use NP Expressions service (elastic#58387)
  Update misc dependencies (elastic#59542)
  [Unit Testing] Configure react-testing-library queries to use Kibana's data-test-subj instead of default data-testid (elastic#59445)
  [Console] Remove unused code (elastic#59554)
  [Logs / Metrics UI] Link handling / stop page reloads (elastic#58478)
  Add SavedObject management section registration in core  (elastic#59291)
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 11, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Mar 12, 2020
@elasticmachine @jkelastic
Move canvas to use NP Expressions service (elastic#58387)
375d00f 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

crob611 pushed a commit that referenced this pull request Mar 13, 2020
@elasticmachine
Move canvas to use NP Expressions service (#58387) (#59749)
54c7a4b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 13, 2020
@streamich streamich mentioned this pull request Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
Feature:NP Migration loe:large Large Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crob611 @elasticmachine @kibanamachine @poffdeluxe @streamich