Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Endpoint] Sample data generator for endpoint app #58936
[Endpoint] Sample data generator for endpoint app #58936
Changes from 17 commits
be66b5b
fc0279f
1655df5
9c0b912
52efc27
5073fdc
c1bf5d8
69a9221
bdfd9b4
027929a
c333e87
cf96f10
4bc37d4
bf6a055
f82ef50
8a6bcbf
bfd320f
9bf2bf3
e1f6df2
de3b9b7
3ead579
07fa69c
7006c4f
d1df9fd
1ee15a0
5f38e3a
aa77f8d
ba621f6
041a34f
469418e
3f16642
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in reference to the later comment about 'snapshot' testing, you could try this instead:
Save the file, then run the tests (or if you're using
--watch
, no need.) The test framework will serializeprocessEvent
and drop a serialized version into this file. If the serialization changes, the test will fail. Not the best for every type of test, but in this case it might be worth trying out.Another thing, if the serialization is really long/big, you can write
toMatchSnapshot()
instead and the serialization will be saved in a separate file.One possible downside to using snapshots is that the intent of the assertion can be lost to the reader. In your test here for example, I can tell that the
'@timestamp'
field should match thetimestamp
variable, but that might not be obvious if there is just a single snapshot assertion. In this case, you can make the test description longer, like 'it creates process events, using the passed-in timestamp to populate timestamp fields.'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would probably be better to break some of these assertions into separate
it
's. You could have something like: