Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ci type check errors for alerting and actions properties for SIEM RouteHandlerContext #59400

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Fixed ci type check errors for alerting and actions properties for SIEM RouteHandlerContext #59400

merged 3 commits into from
Mar 5, 2020

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 5, 2020
@YulNaumenko YulNaumenko self-assigned this Mar 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

FrankHassanabad
FrankHassanabad approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for figuring out quickly how we do things and finding the mis-merge.

@YulNaumenko YulNaumenko requested a review from a team as a code owner March 5, 2020 05:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pmuellr
pmuellr approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikecote
mikecote approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YulNaumenko YulNaumenko merged commit 4883d4b into elastic:master Mar 5, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 5, 2020
@YulNaumenko
Fixed ci type check errors for alerting and actions properties for SI…
74e0aef 
…EM RouteHandlerContext (elastic#59400)

* Fixed ci type check errors for alerting and actions optional properties on RouteHandlerContext

* Reverted git revert b83f814
@YulNaumenko YulNaumenko mentioned this pull request Mar 5, 2020
Merged
YulNaumenko added a commit that referenced this pull request Mar 5, 2020
@YulNaumenko
Fixed ci type check errors for alerting and actions properties for SI…
ee29a5d 
…EM RouteHandlerContext (#59400) (#59442)

* Fixed ci type check errors for alerting and actions optional properties on RouteHandlerContext

* Reverted git revert b83f814
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Mar 12, 2020
@YulNaumenko @jkelastic
Fixed ci type check errors for alerting and actions properties for SI…
65a4742 
…EM RouteHandlerContext (elastic#59400)

* Fixed ci type check errors for alerting and actions optional properties on RouteHandlerContext

* Reverted git revert b83f814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@mikecote mikecote mikecote approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YulNaumenko @elasticmachine @kibanamachine @pmuellr @FrankHassanabad @mikecote