[SIEM][Case] Update connector through flyout

[cnasikas]

Summary

The PR changes the behavior of updating a connector. Specifically, a connector will be updated through the edit flyout of trigger_actions_ui plugin.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/siem (Team:SIEM)

[stephmilovic]

A few issues discovered manual testing:

• If we don't have a connector selected, the Update connector link/button should be disabled

I'm seeing an `uncontrolled/controlled input` console error when I open the flyout ...

react_devtools_backend.js:6 Warning: A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components
    in input (created by EuiValidatableControl)
    in EuiValidatableControl (created by EuiFieldText)
    in div (created by EuiFormControlLayout)
    in div (created by EuiFormControlLayout)
    in EuiFormControlLayout (created by EuiFieldText)
    in EuiFieldText (created by ServiceNowConnectorFields)
    in div (created by EuiFormRow)
    in div (created by EuiFormRow)
    in EuiFormRow (created by ServiceNowConnectorFields)
    in div (created by EuiFlexItem)
    in EuiFlexItem (created by ServiceNowConnectorFields)
    in div (created by EuiFlexGroup)
    in EuiFlexGroup (created by ServiceNowConnectorFields)
    in ServiceNowConnectorFields (created by ActionConnectorForm)
    in div (created by EuiForm)
    in EuiForm (created by ActionConnectorForm)
    in ActionConnectorForm (created by ConnectorAddFlyout)
    in div (created by EuiFlyoutBody)
    in div (created by EuiFlyoutBody)
    in div (created by EuiFlyoutBody)
    in EuiFlyoutBody (created by ConnectorAddFlyout)
    in div (created by EuiFlyout)
    in div (created by FocusLock)
    in FocusLock (created by EuiFocusTrap)
    in div (created by OutsideEventDetector)
    in OutsideEventDetector (created by EuiFocusTrap)
    in EuiOutsideClickDetector (created by EuiFocusTrap)
    in EuiFocusTrap (created by EuiFlyout)
    in EuiFlyout (created by ConnectorAddFlyout)
    in ConnectorAddFlyout (created by ConfigureCasesComponent)
    in ActionsConnectorsContextProvider (created by ConfigureCasesComponent)
    in div (created by FormWrapper)
    in FormWrapper (created by ConfigureCasesComponent)
    in ConfigureCasesComponent (created by ConfigureCasesPageComponent)
    in div (created by WhitePageWrapper)
    in WhitePageWrapper (created by ConfigureCasesPageComponent)
    in div (created by Wrapper)
    in Wrapper (created by WrapperPageComponent)
    in WrapperPageComponent (created by ConfigureCasesPageComponent)
    in ConfigureCasesPageComponent (created by CaseContainerComponent)
    in Route (created by CaseContainerComponent)
    in Switch (created by CaseContainerComponent)
    in CaseContainerComponent (created by Query)
    in Route (created by Query)
    in Switch (created by Query)
    in Provider (created by App)
    in App (created by ErrorBoundary)
    in ErrorBoundary (created by DragDropContext)
    in DragDropContext
    in Unknown
    in Unknown (created by ConnectFunction)
    in ConnectFunction (created by Query)
    in Query
    in Unknown (created by HomePage)
    in main (created by Main)
    in Main (created by HomePage)
    in div (created by WrappedByAutoSizer)
    in WrappedByAutoSizer (created by HomePage)
    in HomePage (created by PageRouterComponent)
    in Route (created by PageRouterComponent)
    in Switch (created by PageRouterComponent)
    in Router (created by PageRouterComponent)
    in ManageRoutesSpyComponent (created by PageRouterComponent)
    in PageRouterComponent (created by AppPluginRootComponent)
    in Unknown (created by AppPluginRootComponent)
    in ThemeProvider (created by AppPluginRootComponent)
    in ApolloProvider (created by AppPluginRootComponent)
    in Provider (created by AppPluginRootComponent)
    in ManageGlobalToaster (created by AppPluginRootComponent)
    in AppPluginRootComponent (created by StartAppComponent)
    in EuiContext (created by I18nContext)
    in PseudoLocaleWrapper (created by I18nProvider)
    in IntlProvider (created by I18nProvider)
    in I18nProvider (created by I18nContext)
    in I18nContext (created by StartAppComponent)
    in EuiErrorBoundary (created by StartAppComponent)
    in StartAppComponent (created by SiemAppComponent)
    in Provider (created by SiemAppComponent)
    in SiemAppComponent

this can be resolved in a different PR, but i realize that the Cancel button here does not do anything. and Save Changes is only having an effect on the radio. maybe we should just do the call when the radio is toggled and not have any buttons?

[cnasikas]

A few issues discovered manual testing:

• If we don't have a connector selected, the Update connector link/button should be disabled

I'm seeing an uncontrolled/controlled input console error when I open the flyout ...
this can be resolved in a different PR, but i realize that the Cancel button here does not do anything. and Save Changes is only having an effect on the radio. maybe we should just do the call when the radio is toggled and not have any buttons?

I fixed the first two issues. The third issue, as you said, will be resolved in another PR and it will follow the UI design. You are right about the Cancel button. Now that the mapping is updating through the flyout maybe there is no need for it.

[cnasikas]

@elasticmachine merge upstream

[cnasikas]

@elasticmachine merge upstream

[stephmilovic]

Thanks for turning this around so quickly, LGTM 🎸 🚀

[cnasikas]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: d7f8045

History

• 💔 Build #33972 failed fb73c11
• 💚 Build #33775 succeeded b78ca8b
• 💚 Build #33725 succeeded d7118a1
• 💚 Build #33612 succeeded 37b78f5
• 💔 Build #33575 failed 3530313

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream