Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Add additional safeguards for data source wizard step 2 #60426

Merged
merged 2 commits into from
Mar 17, 2020
Merged

[Ingest] Add additional safeguards for data source wizard step 2 #60426

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1942dc1
Add additional safeguards for data source wizard step 2
jen-huang Mar 17, 2020
c8c63fd
Merge branch 'master' into ingest/input-check
elasticmachine Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ingest_manager/sections/agent_config/create_datasource_page/step_configure_datasource.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,10 @@ export const StepConfigureDatasource: React.FunctionComponent<{
// Step B, configure inputs (and their streams)
// Assume packages only export one datasource for now
const ConfigureInputs =
packageInfo.datasources && packageInfo.datasources[0] ? (
packageInfo.datasources &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about using typescript coalescing here(packageInfo.datasources?.[0]?.inputs?.length ?? false) ? (<>) :

packageInfo.datasources[0] &&
packageInfo.datasources[0].inputs &&
packageInfo.datasources[0].inputs.length ? (
<EuiFlexGroup direction="column">
{packageInfo.datasources[0].inputs.map(packageInput => {
const datasourceInput = datasource.inputs.find(input => input.type === packageInput.type);
Expand Down