[SIEM] [Cases] Case closed and add user email #60463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2020
stephmilovic
changed the title
stephmilovic
added
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
6 tasks
cnasikas
reviewed
Mar 18, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Mar 18, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/user_list/index.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Mar 18, 2020
| closed_by: { email, full_name, username }, | ||
| }; | ||
| } else if (updateCaseAttributes.status && updateCaseAttributes.status === 'open') { | ||
| closedInfo = { |
There was a problem hiding this comment.
Do we need it with null values?
There was a problem hiding this comment.
I'd like it to be. Otherwise a case will be open and give 'closed_at' times... isnt that weird? We'll have this all tracked in user_actions anyways I think??
6 tasks
cnasikas
reviewed
Mar 18, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/case_view/actions.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Mar 18, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cnasikas
reviewed
Mar 19, 2020
| @@ -50,7 +57,8 @@ const renderUsers = (users: ElasticUser[]) => { | |||
| </EuiFlexItem> | |||
| <EuiFlexItem grow={false}> | |||
| <EuiButtonIcon | |||
| onClick={() => {}} // TO DO | |||
| data-test-subj="user-list-email-button" | |||
| onClick={handleSendEmail.bind(null, email)} // TO DO | |||
There was a problem hiding this comment.
oh no longer a todo! im a green build tho so ill remove it in a future PR
cnasikas
reviewed
Mar 19, 2020
| export const UserList = React.memo(({ email, headline, users }: UserListProps) => { | ||
| const handleSendEmail = useCallback( | ||
| (emailAddress: string | undefined | null) => { | ||
| if (emailAddress && emailAddress != null) { |
There was a problem hiding this comment.
nit: if(emailAddress) or !isEmpty(emailAddress)
There was a problem hiding this comment.
green build, ill get it soon tho
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Mar 19, 2020
stephmilovic
added a commit
that referenced
this pull request
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the remaining All Cases issues from #59041:
This PR resolves the following Case View issues from #58526:
connect mailto actions
display closed at time when case is closed
This PR makes updates to the API noted in this issue, #58525
Note to reviewer: I did not add new tests to
all_cases/index.test.tsxbecause it's going to give me a merge headache with my other PR. once my other PR is merged, I will add tests for the closed at column in all_cases