[Lens] Use suggestion system in chart switcher for subtypes #60669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
timroes
reviewed
Mar 23, 2020
| @@ -94,7 +97,7 @@ export const metricVisualization: Visualization<State, PersistableState> = { | |||
| groupLabel: i18n.translate('xpack.lens.metric.label', { defaultMessage: 'Metric' }), | |||
| layerId: props.state.layerId, | |||
| accessors: props.state.accessor ? [props.state.accessor] : [], | |||
| supportsMoreColumns: false, | |||
| supportsMoreColumns: !props.state.accessor, | |||
There was a problem hiding this comment.
Could you shortly explain how this is related to that change and what it does?
There was a problem hiding this comment.
This is actually a separate issue. Need to fix separately.
mbondyra
approved these changes
Mar 26, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
Closing this as this was mostly for use in the pie chart/treemap, and this isn't strictly needed. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR has no user-facing changes yet, but it will be used by Pie charts and Treemaps. The reason this change is necessary is the following scenario:
Checklist