Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Fix config value type and schema #60688

Merged
merged 1 commit into from
Mar 20, 2020
Merged

[Ingest] Fix config value type and schema #60688

merged 1 commit into from
Mar 20, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Due to changes in #60406, adding a datasource with config fields that have {value: unknown} fails. This PR allows value to be undefined.

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project v7.7.0 labels Mar 19, 2020
@jen-huang jen-huang requested a review from a team March 19, 2020 21:00
@jen-huang jen-huang self-assigned this Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

nchaulet
nchaulet approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit 22f14b5 into elastic:master Mar 20, 2020
@jen-huang jen-huang deleted the ingest/fix/ds-schema branch March 20, 2020 16:54
@jen-huang jen-huang mentioned this pull request Mar 20, 2020
Merged
jen-huang added a commit that referenced this pull request Mar 20, 2020
@jen-huang
Fix config value type and schema (#60688) (#60776)
f1fc470
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@jen-huang jen-huang

Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jen-huang @elasticmachine @kibanamachine @nchaulet