Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][Detection Engine] Adds test scripts for machine learning feature #60713

Merged
merged 1 commit into from
Mar 20, 2020
Merged

[SIEM][Detection Engine] Adds test scripts for machine learning feature #60713

merged 1 commit into from
Mar 20, 2020

Conversation

FrankHassanabad
Copy link
Contributor

Summary

  • Adds ad-hoc testing scripts for machine learning feature

Testing

./post_rule.sh ./rules/queries/query_with_machine_learning.json
./update_rule.sh ./rules/updates/update_machine_learning.json
./patch_rule.sh ./rules/patches/update_machine_learning.json

@FrankHassanabad FrankHassanabad self-assigned this Mar 19, 2020
@FrankHassanabad FrankHassanabad added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.7.0 labels Mar 19, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd self-requested a review March 20, 2020 21:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@rylnd rylnd mentioned this pull request Mar 20, 2020
Merged
rylnd
rylnd approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrankHassanabad LGTM. This uncovered another ML bug (#60830), so thank you!

@FrankHassanabad FrankHassanabad merged commit 74ceceb into elastic:master Mar 20, 2020
@FrankHassanabad FrankHassanabad deleted the adds-scripts-for-machine-learning branch March 20, 2020 23:33
@FrankHassanabad FrankHassanabad mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FrankHassanabad @kibanamachine @elasticmachine @rylnd @patrykkopycinski