Settings sections registry #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,10 +13,10 @@ define(function (require) { | |||
| $scope.buildSha = buildSha; | |||
| }); | |||
|
|
|||
| return { | |||
| registry.register(() => ({ | |||
There was a problem hiding this comment.
I'm not a fan of this syntax. I personally think it's a lot more readable as:
() => {
return {
// ...
};
}
|
This is awesome, nice work @lukasolson. |
|
I don’t think About should be Infinity, we should allow users to inject after it. Setting it to 1001 is sufficient. Otherwise, LGETM |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new registry,
settings_sections, and switches over the existing settings sections to register themselves. This also allows plugins to register their own settings sections.Closes #6016.