Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [SIEM] Fix patching of ML Rules (#60830) #60844

Merged
merged 1 commit into from
Mar 22, 2020
Merged

[7.x] [SIEM] Fix patching of ML Rules (#60830) #60844

merged 1 commit into from
Mar 22, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Mar 21, 2020

Backports the following commits to 7.x:

@rylnd @elasticmachine
[SIEM] Fix patching of ML Rules (elastic#60830)
643f54d 
* Allow ML Rules to be patched

* Test passing of params from our patch routes to our helpers

Since patchRules accepts a partial there's no way to verify this in
typescript, we need regression tests instead.

* Update lists when importing with overwrite

This was simply missed earlier.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rylnd rylnd added the backport label Mar 21, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd added the release_note:skip Skip the PR/issue when compiling release notes label Mar 22, 2020
@rylnd rylnd merged commit 77c8de1 into elastic:7.x Mar 22, 2020
@rylnd rylnd deleted the backport/7.x/pr-60830 branch March 22, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylnd @kibanamachine