[Alerting] Fixes flaky test in Alert Instances Details page #60893
Conversation
gmmorris
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
code LGTM, made a few comments
I'm still a little worried this may be flaky, due to perhaps rounding errors in the time, roll-overs in seconds, etc. Feel like eventually we're going to need to build some "slop" into the check, like ensuring the values are within a range of what we expect, instead of exact values. But if this works for now, awesome!
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts
Outdated
Show resolved
Hide resolved
The new approach to the test ensures we're using the same base time so, in theory, there shouldn't be any need for slop anymore. We'll find out if it still behaves flaky. At which point, the best investment of our time would be to remove the fake durations all together by getting the event log work done. |
…s/kibana into alerting/fix-duration-flaky-test * 'alerting/fix-duration-flaky-test' of github.com:gmmorris/kibana: [ML] Fixing app clean up (elastic#60853) [SIEM] Use ECS categorisation for Authentication widgets (elastic#60734)
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…60893) Fixes flaky test in Alert Instances Details page
* master: (26 commits) [Alerting] Fixes flaky test in Alert Instances Details page (elastic#60893) cleanup visualizations api (elastic#59958) Inline timezoneProvider function, remove ui/vis/lib/timezone (elastic#60475) [SIEM] Adds 'Open one signal' Cypress test (elastic#60484) [UA] Upgrade assistant migration meta data can become stale (elastic#60789) [Metrics Alerts] Remove metric field from doc count on backend (elastic#60679) [Uptime] Skip failing location test temporarily (elastic#60938) [ML] Disabling datafeed editing when job is running (elastic#60751) Adding `authc.invalidateAPIKeyAsInternalUser` (elastic#60717) [SIEM] Add license check to ML Rule form (elastic#60691) Adding `authc.grantAPIKeyAsInternalUser` (elastic#60423) Support Histogram Data Type (elastic#59387) [Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (elastic#60770) [SIEM] [Cases] Update case icons (elastic#60812) [TSVB] Fix percentiles band mode (elastic#60741) Fix formatter on range aggregation (elastic#58651) Goodbye, legacy data plugin 👋 (elastic#60449) [Metrics UI] Alerting for metrics explorer and inventory (elastic#58779) [Remote clustersadopt changes to remote info API (elastic#60795) Only run xpack siem cypress in PRs when there are siem changes (elastic#60661) ...
Summary
closes #57426
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers