-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Allow user to drag and select a subset of the timeline in the chart (aka brush interaction) #62636
Merged
Merged
[Lens] Allow user to drag and select a subset of the timeline in the chart (aka brush interaction) #62636
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c213932
feat: brushing basic example for time histogram
mbondyra 8c99c2d
test: added
mbondyra 0e83e13
refactor: simplify the structure
mbondyra e868030
Merge branch 'master' into brushing-on-lens
elasticmachine 4ff7e63
refactor: move to inline function
mbondyra e984281
refactor
mbondyra 5806bd6
Merge branch 'master' into brushing-on-lens
elasticmachine 8e23141
refactor
mbondyra 5a6bfe9
Merge branch 'master' into brushing-on-lens
elasticmachine 609b8c0
Merge remote-tracking branch 'origin/master' into HEAD
wylieconlon 436cc5a
Always use time field from index pattern
wylieconlon b162d60
types
mbondyra f6228cb
use the meta.aggConfigParams for timefieldName
mbondyra 1fb9a9d
Merge commit 'fdc962f348ed54c63e49c8f745753caadf394ad6' into brushing…
mbondyra 3b59c4b
fix: test snapshot update
mbondyra 61695ad
Update embeddable.tsx
mbondyra 789baf1
Merge branch 'master' into brushing-on-lens
elasticmachine 006c9cf
Merge commit 'ffc8741da2ffcf4d31ae3ccc143fd483a61cbb1b' into brushing…
mbondyra 7ce6088
fix: moment remov
mbondyra 0919adc
Merge branch 'master' into brushing-on-lens
elasticmachine 793aaa1
Merge branch 'master' into brushing-on-lens
elasticmachine 19ae66f
Merge commit '6e2691358fdb59af717a9aaa2b32887b9cdf2d2a' into brushing…
mbondyra a3491ee
fix: corrections for adapting to timepicker on every timefield
mbondyra 6c94c86
fix: fix single bar condition
mbondyra 674564a
types
mbondyra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
x-pack/legacy/plugins/lens/public/xy_visualization/__snapshots__/to_expression.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
7 changes: 7 additions & 0 deletions
7
x-pack/legacy/plugins/lens/public/xy_visualization/__snapshots__/xy_expression.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left this comment in a few places, but it will hopefully simplify this test too: we should not use the table metadata, because it's specific to only one data source.