[Logs UI] Alerting #62806

Kerry350 · 2020-04-07T14:42:51Z

Summary

This PR implements #61493. It adds the "core" of the first iteration of logs alerting. The end-to-end flow when adding an alert via the logs app should work.

Followups

Due to the size of this PR, and also working in parellel with other PRs, the following is to come in the next PR:

Alert management screen changes: there are caveats to editing an alert on the alerts management screen (i.e. the things you have access to via context). This flow will be addressed next, and should be considered broken with the work here. In part this is so that [Logs UI] Reimplement log source configuration routes in plain HTTP+JSON #64021 can be merged first, which addresses one of the issues there without having to create a workaround.
Tests. I would like to add executor tests at least.
The occur text mentioned here (after speaking with Felix this will appear after the "when log entries" line).
Add a proper loading state to show when the fields data is loading (easier with the new logs source config hook).

Testing

SSL is necessary, which can be facilitated with:

yarn es snapshot --ssl
yarn start --ssl

And adding ssl.verification_mode: none in the Filebeat config.

…end type

…f route handler contexts (like the alert executor)

elasticmachine · 2020-04-23T16:05:44Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Kerry350 · 2020-04-23T16:09:37Z

@Zacqary I've added you as the reviewer for this, please let me know if that's not okay. The only big(ish) caveat is the alerts management screen, which will be addressed in a followup.

Zacqary

Overall looks really good, couple of UX suggestions though

x-pack/plugins/infra/public/components/alerting/logs/expression_editor/criterion.tsx

Zacqary · 2020-04-23T17:13:40Z

x-pack/plugins/infra/public/components/alerting/logs/expression_editor/criterion.tsx

+                          }}
+                        />
+                      ) : (
+                        <EuiFieldText


How about we add some double quotes around the <EuiFieldText> to signify that it's a string value instead of a number?

Hmm, I think this could potentially mislead / frustrate people. I understand the intention, but I can also see people entering error and then seeing "error" and thinking "huh, I haven't added quotations".

Or, if there's a scenario where people actually want to have the quotations as part of the value they're matching, we either need to display double quotes which is messy, or not render them if the user has used quotes in the value. This again leads to a misleading situation.

I think it might be best to leave this one? Or defer to design for the next iteration?

Okay we can leave this. Changing EQUALS to IS should be good enough.

Zacqary · 2020-04-23T17:52:41Z

...k/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts

-export async function registerMetricThresholdAlertType(alertingPlugin: PluginSetupContract) {
+export async function registerMetricThresholdAlertType(
+  alertingPlugin: PluginSetupContract,
+  libs: InfraBackendLibs


libs is unused in this alert type, and on my end it doesn't look like we need to add this arg to get it to pass type check. Am I missing something?

This was mostly laziness to deal with:

registerFns.forEach(fn => { fn(alertingPlugin, libs); });

it was easier just to pass them both the libs.

As the work Philip and I are doing has some overlap here, where we've both refactored the source configuration code and allowed access to libs in executors, and Philip has refactored this forEach line, I think it would be easier just to leave this for this merge. And deal with the small conflict that will arise in Philip's branch.

// cc @phillipb

Sounds good, we can do that.

Kerry350 · 2020-04-27T10:36:33Z

@Zacqary Thanks for the review 👍 I've responded to your feedback, if you could take another look.

Zacqary

Looks good!

kibanamachine · 2020-04-27T14:50:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 92de5b8

History

💔 Build #43336 failed e3f201c
💔 Build #43329 failed aeaac32
💚 Build #42780 succeeded 4a3380b
💔 Build #42750 failed 7942328
💚 Build #42151 succeeded b91688c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

First iteration of logs alerting

…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (152 commits) [Ingest pipelines] Simulate pipeline (elastic#64223) Ability to get scoped call cluster from alerting and action executors (elastic#64432) Add editApp and editPath to embeddable (elastic#64297) TSVB validation: Allow numeric values for axes (elastic#63553) [ML] Fixing optional plugin dependency types (elastic#64450) [Logs UI] Alerting (elastic#62806) [Endpoint] Show Policy Status on Host Details using Policy Response API (elastic#64116) [Maps] update LayerWizard previewLayer to take layerDescriptor instead of ISource (elastic#64461) Remove SO root property index signature (elastic#64434) [ML] Functional tests - stabilize job row details validations (elastic#64503) [Ingest] Add Global settings flyout (elastic#64276) Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408) Migrate saved object of type url to kibana platform (elastic#64043) [NP] Migrate ui capabilities (elastic#64185) Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407) Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149) Remove SO autocreateindex error and error page (elastic#64037) Fix issue with yarn.lock (elastic#64496) Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433) Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/shared_imports.ts

Zacqary and others added 4 commits April 3, 2020 12:40

[Logs UI Alerting] Bootstrap with skeleton of alert typedef and front…

ea12307

…end type

Merge remote-tracking branch 'upstream/master' into logs-alerting

99d3110

Amend schema and add alert dropdown menu

8a68de3

Register public side of AlertType

a2b4fae

Zacqary mentioned this pull request Apr 7, 2020

[Logs UI Alerting] Bootstrap with skeleton of alert typedef and frontend type #62496

Closed

Kerry350 added 17 commits April 8, 2020 16:22

Document count portion of expression editor

4af8470

Start of criteria

295c223

Merge remote-tracking branch 'upstream/master' into logs-alerting

d7cafd4

(Most of) criteria selection

2bd61dc

Add "for the last" functionality

e906ff6

Add ability to add more criteria

c18a7e1

Merge remote-tracking branch 'upstream/master' into logs-alerting

34c629b

Add ability to remove criterion

7f6e9f7

Add bulk of UI validation logic

cc14109

Merge remote-tracking branch 'upstream/master' into logs-alerting

8f0050b

Ensure compatibility between field and comparator / value

1a37346

Change getSourceConfiguration dependencies so we can use it outside o…

ba482ec

…f route handler contexts (like the alert executor)

Pull index pattern into executor through sources library

12e2270

Executor and ActionVariable logic

603ccb8

Merge remote-tracking branch 'upstream/master' into logs-alerting

3cd7453

Move types to /common

023edda

Full typing for executor function

b44a04b

Kerry350 mentioned this pull request Apr 20, 2020

[Logs UI Alerting] Create alert type and executor #61500

Closed

Kerry350 added 7 commits April 20, 2020 16:36

Client side typing

be0cdb7

Amend source config tests

74dcaba

Merge remote-tracking branch 'upstream/master' into logs-alerting

6a158d8

Ensure i18n

b923d0a

Tweak / polish styling

b91688c

Merge remote-tracking branch 'upstream/master' into logs-alerting

3063455

Merge remote-tracking branch 'upstream/master' into logs-alerting

f717a51

Kerry350 added v7.8.0 v8.0.0 Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Apr 23, 2020

Kerry350 removed the Feature:Metrics UI Metrics UI feature label Apr 23, 2020

Kerry350 requested a review from Zacqary April 23, 2020 16:07

Kerry350 marked this pull request as ready for review April 23, 2020 16:07

Kerry350 requested a review from a team as a code owner April 23, 2020 16:07

Zacqary requested changes Apr 23, 2020

View reviewed changes

Zacqary mentioned this pull request Apr 23, 2020

[Alerting] Add a required, programmatic message to actions #64349

Open

Kerry350 added 3 commits April 27, 2020 09:47

Merge remote-tracking branch 'upstream/master' into logs-alerting

adc5deb

Differentiate string / number wording

b3ee986

Re-throw Error

aeaac32

Kerry350 added the Feature:Alerting label Apr 27, 2020

Kerry350 added 2 commits April 27, 2020 12:01

Differentiate singular vs plural for document count

e3f201c

Fix duplicate i18n IDs

92de5b8

Zacqary approved these changes Apr 27, 2020

View reviewed changes

Kerry350 merged commit 72fba8b into elastic:master Apr 27, 2020

Kerry350 mentioned this pull request Apr 27, 2020

[7.x] [Logs UI] Alerting (#62806) #64530

Merged

Kerry350 added a commit to Kerry350/kibana that referenced this pull request Apr 27, 2020

[Logs UI] Alerting (elastic#62806)

8610d36

First iteration of logs alerting

Kerry350 added a commit that referenced this pull request Apr 28, 2020

[Logs UI] Alerting (#62806) (#64530)

1db5360

First iteration of logs alerting

This was referenced Jul 5, 2021

[Logs UI][Test Scenario] Log threshold alerts (general) #104297

Closed

[Logs UI] [Test Scenario] Log threshold alerts (count configuration) #104353

Closed

[Logs UI] [Test Scenario] Log threshold alerts (ratio configuration) #104354

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI] Alerting #62806

[Logs UI] Alerting #62806

Kerry350 commented Apr 7, 2020 •

edited

Loading

elasticmachine commented Apr 23, 2020

Kerry350 commented Apr 23, 2020

Zacqary left a comment

Zacqary Apr 23, 2020

Kerry350 Apr 27, 2020

Zacqary Apr 27, 2020

Zacqary Apr 23, 2020

Kerry350 Apr 27, 2020

Kerry350 Apr 27, 2020 •

edited

Loading

Zacqary Apr 27, 2020

Kerry350 commented Apr 27, 2020

Zacqary left a comment

kibanamachine commented Apr 27, 2020

[Logs UI] Alerting #62806

[Logs UI] Alerting #62806

Conversation

Kerry350 commented Apr 7, 2020 • edited Loading

Summary

Followups

Testing

elasticmachine commented Apr 23, 2020

Kerry350 commented Apr 23, 2020

Zacqary left a comment

Choose a reason for hiding this comment

Zacqary Apr 23, 2020

Choose a reason for hiding this comment

Kerry350 Apr 27, 2020

Choose a reason for hiding this comment

Zacqary Apr 27, 2020

Choose a reason for hiding this comment

Zacqary Apr 23, 2020

Choose a reason for hiding this comment

Kerry350 Apr 27, 2020

Choose a reason for hiding this comment

Kerry350 Apr 27, 2020 • edited Loading

Choose a reason for hiding this comment

Zacqary Apr 27, 2020

Choose a reason for hiding this comment

Kerry350 commented Apr 27, 2020

Zacqary left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 27, 2020

💚 Build Succeeded

History

Kerry350 commented Apr 7, 2020 •

edited

Loading

Kerry350 Apr 27, 2020 •

edited

Loading