Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize typing in mml input #63091

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Apr 9, 2020

Summary

This PR wraps the model memory value setting during anomaly detection wizards in a retry.

This is done in order to cover the rare case of the estimation request coming back while the field is empty and thus leading to values like 26MB1100mb.

Closes #62554

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Apr 9, 2020
@pheyos pheyos requested a review from a team as a code owner April 9, 2020 09:18
@pheyos pheyos self-assigned this Apr 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented Apr 9, 2020

Checking stability in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/354/ ...
=> No failure in 40 runs.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 530732c into elastic:master Apr 9, 2020
@pheyos pheyos deleted the stabilize_ad_mml_typing branch April 9, 2020 12:03
pheyos added a commit to pheyos/kibana that referenced this pull request Apr 9, 2020
This PR wraps the model memory value setting during anomaly detection wizards in a retry.
pheyos added a commit to pheyos/kibana that referenced this pull request Apr 9, 2020
This PR wraps the model memory value setting during anomaly detection wizards in a retry.
pheyos added a commit that referenced this pull request Apr 9, 2020
This PR wraps the model memory value setting during anomaly detection wizards in a retry.
pheyos added a commit that referenced this pull request Apr 9, 2020
This PR wraps the model memory value setting during anomaly detection wizards in a retry.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 9, 2020
…chore/put-all-xjson-together

* 'master' of github.com:elastic/kibana:
  [EPM] Update UI copy to use `integration` (elastic#63077)
  [NP] Inline buildPointSeriesData and buildHierarchicalData dependencies (elastic#61575)
  [Maps] create NOT EXISTS filter for tooltip property with no value (elastic#62849)
  [Endpoint] Add link to Logs UI to the Host Details view (elastic#62852)
  [UI COPY] Fixes typo in max_shingle_size for search_as_you_type (elastic#63071)
  [APM] docs: add alerting examples for APM (elastic#62864)
  [EPM] Change PACKAGES_SAVED_OBJECT_TYPE id (elastic#62818)
  docs: fix rendering of bulleted list (elastic#62855)
  Exposed AddMessageVariables as separate component (elastic#63007)
  Add Data - Adding cloud reset password link to cloud instructions (elastic#62835)
  [ML] DF Analytics:  update memory estimate after adding exclude fields (elastic#62850)
  [Table Vis] Fix visualization overflow (elastic#62630)
  [Endpoint][EPM] Endpoint depending on ingest manager to initialize (elastic#62871)
  [Remote clusters] Fix flaky jest tests (elastic#58768)
  [Discover] Hide time picker when an indexpattern without timefield is selected (elastic#62134)
  Move search source parsing and serializing to data (elastic#59919)
  [ML] Functional tests - stabilize typing in mml input (elastic#63091)
  [data.search.aggs]: Clean up TimeBuckets implementation (elastic#62123)
  [ML] Functional transform tests - stabilize source selection (elastic#63087)
  add embed flag to saved object url as well (elastic#62926)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/es_index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants